SynchronizedTest.cpp 29 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037
  1. /*
  2. * Copyright 2011-present Facebook, Inc.
  3. *
  4. * Licensed under the Apache License, Version 2.0 (the "License");
  5. * you may not use this file except in compliance with the License.
  6. * You may obtain a copy of the License at
  7. *
  8. * http://www.apache.org/licenses/LICENSE-2.0
  9. *
  10. * Unless required by applicable law or agreed to in writing, software
  11. * distributed under the License is distributed on an "AS IS" BASIS,
  12. * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  13. * See the License for the specific language governing permissions and
  14. * limitations under the License.
  15. */
  16. // @author: Andrei Alexandrescu (aalexandre)
  17. // Test bed for folly/Synchronized.h
  18. #include <folly/Synchronized.h>
  19. #include <folly/Function.h>
  20. #include <folly/LockTraitsBoost.h>
  21. #include <folly/Portability.h>
  22. #include <folly/ScopeGuard.h>
  23. #include <folly/SharedMutex.h>
  24. #include <folly/SpinLock.h>
  25. #include <folly/portability/GTest.h>
  26. #include <folly/synchronization/RWSpinLock.h>
  27. #include <folly/test/SynchronizedTestLib.h>
  28. using namespace folly::sync_tests;
  29. namespace folly {
  30. template <class Mutex>
  31. class SynchronizedTest : public testing::Test {};
  32. using SynchronizedTestTypes = testing::Types<
  33. folly::SharedMutexReadPriority,
  34. folly::SharedMutexWritePriority,
  35. std::mutex,
  36. std::recursive_mutex,
  37. #if FOLLY_LOCK_TRAITS_HAVE_TIMED_MUTEXES
  38. std::timed_mutex,
  39. std::recursive_timed_mutex,
  40. #endif
  41. boost::mutex,
  42. boost::recursive_mutex,
  43. #if FOLLY_LOCK_TRAITS_HAVE_TIMED_MUTEXES
  44. boost::timed_mutex,
  45. boost::recursive_timed_mutex,
  46. #endif
  47. #ifdef RW_SPINLOCK_USE_X86_INTRINSIC_
  48. folly::RWTicketSpinLock32,
  49. folly::RWTicketSpinLock64,
  50. #endif
  51. boost::shared_mutex,
  52. folly::SpinLock>;
  53. TYPED_TEST_CASE(SynchronizedTest, SynchronizedTestTypes);
  54. TYPED_TEST(SynchronizedTest, Basic) {
  55. testBasic<TypeParam>();
  56. }
  57. TYPED_TEST(SynchronizedTest, WithLock) {
  58. testWithLock<TypeParam>();
  59. }
  60. TYPED_TEST(SynchronizedTest, Unlock) {
  61. testUnlock<TypeParam>();
  62. }
  63. TYPED_TEST(SynchronizedTest, Deprecated) {
  64. testDeprecated<TypeParam>();
  65. }
  66. TYPED_TEST(SynchronizedTest, Concurrency) {
  67. testConcurrency<TypeParam>();
  68. }
  69. TYPED_TEST(SynchronizedTest, AcquireLocked) {
  70. testAcquireLocked<TypeParam>();
  71. }
  72. TYPED_TEST(SynchronizedTest, AcquireLockedWithConst) {
  73. testAcquireLockedWithConst<TypeParam>();
  74. }
  75. TYPED_TEST(SynchronizedTest, DualLocking) {
  76. testDualLocking<TypeParam>();
  77. }
  78. TYPED_TEST(SynchronizedTest, DualLockingWithConst) {
  79. testDualLockingWithConst<TypeParam>();
  80. }
  81. TYPED_TEST(SynchronizedTest, ConstCopy) {
  82. testConstCopy<TypeParam>();
  83. }
  84. TYPED_TEST(SynchronizedTest, InPlaceConstruction) {
  85. testInPlaceConstruction<TypeParam>();
  86. }
  87. TYPED_TEST(SynchronizedTest, Exchange) {
  88. testExchange<TypeParam>();
  89. }
  90. template <class Mutex>
  91. class SynchronizedTimedTest : public testing::Test {};
  92. using SynchronizedTimedTestTypes = testing::Types<
  93. #if FOLLY_LOCK_TRAITS_HAVE_TIMED_MUTEXES
  94. std::timed_mutex,
  95. std::recursive_timed_mutex,
  96. boost::timed_mutex,
  97. boost::recursive_timed_mutex,
  98. boost::shared_mutex,
  99. #endif
  100. #ifdef RW_SPINLOCK_USE_X86_INTRINSIC_
  101. folly::RWTicketSpinLock32,
  102. folly::RWTicketSpinLock64,
  103. #endif
  104. folly::SharedMutexReadPriority,
  105. folly::SharedMutexWritePriority>;
  106. TYPED_TEST_CASE(SynchronizedTimedTest, SynchronizedTimedTestTypes);
  107. TYPED_TEST(SynchronizedTimedTest, Timed) {
  108. testTimed<TypeParam>();
  109. }
  110. TYPED_TEST(SynchronizedTimedTest, TimedSynchronized) {
  111. testTimedSynchronized<TypeParam>();
  112. }
  113. template <class Mutex>
  114. class SynchronizedTimedWithConstTest : public testing::Test {};
  115. using SynchronizedTimedWithConstTestTypes = testing::Types<
  116. #if FOLLY_LOCK_TRAITS_HAVE_TIMED_MUTEXES
  117. boost::shared_mutex,
  118. #endif
  119. #ifdef RW_SPINLOCK_USE_X86_INTRINSIC_
  120. folly::RWTicketSpinLock32,
  121. folly::RWTicketSpinLock64,
  122. #endif
  123. folly::SharedMutexReadPriority,
  124. folly::SharedMutexWritePriority>;
  125. TYPED_TEST_CASE(
  126. SynchronizedTimedWithConstTest,
  127. SynchronizedTimedWithConstTestTypes);
  128. TYPED_TEST(SynchronizedTimedWithConstTest, TimedShared) {
  129. testTimedShared<TypeParam>();
  130. }
  131. TYPED_TEST(SynchronizedTimedWithConstTest, TimedSynchronizeWithConst) {
  132. testTimedSynchronizedWithConst<TypeParam>();
  133. }
  134. using CountPair = std::pair<int, int>;
  135. // This class is specialized only to be uesed in SynchronizedLockTest
  136. class FakeMutex {
  137. public:
  138. void lock() {
  139. ++lockCount_;
  140. }
  141. void unlock() {
  142. ++unlockCount_;
  143. }
  144. static CountPair getLockUnlockCount() {
  145. return CountPair{lockCount_, unlockCount_};
  146. }
  147. static void resetLockUnlockCount() {
  148. lockCount_ = 0;
  149. unlockCount_ = 0;
  150. }
  151. private:
  152. // Keep these two static for test access
  153. // Keep them thread_local in case of tests are run in parallel within one
  154. // process
  155. static FOLLY_TLS int lockCount_;
  156. static FOLLY_TLS int unlockCount_;
  157. };
  158. FOLLY_TLS int FakeMutex::lockCount_{0};
  159. FOLLY_TLS int FakeMutex::unlockCount_{0};
  160. // SynchronizedLockTest is used to verify the correct lock unlock behavior
  161. // happens per design
  162. class SynchronizedLockTest : public testing::Test {
  163. public:
  164. void SetUp() override {
  165. FakeMutex::resetLockUnlockCount();
  166. }
  167. };
  168. /**
  169. * Test mutex to help to automate assertions, taken from LockTraitsTest.cpp
  170. */
  171. class FakeAllPowerfulAssertingMutexInternal {
  172. public:
  173. enum class CurrentLockState { UNLOCKED, SHARED, UPGRADE, UNIQUE };
  174. void lock() {
  175. EXPECT_EQ(this->lock_state, CurrentLockState::UNLOCKED);
  176. this->lock_state = CurrentLockState::UNIQUE;
  177. }
  178. void unlock() {
  179. EXPECT_EQ(this->lock_state, CurrentLockState::UNIQUE);
  180. this->lock_state = CurrentLockState::UNLOCKED;
  181. }
  182. void lock_shared() {
  183. EXPECT_EQ(this->lock_state, CurrentLockState::UNLOCKED);
  184. this->lock_state = CurrentLockState::SHARED;
  185. }
  186. void unlock_shared() {
  187. EXPECT_EQ(this->lock_state, CurrentLockState::SHARED);
  188. this->lock_state = CurrentLockState::UNLOCKED;
  189. }
  190. void lock_upgrade() {
  191. EXPECT_EQ(this->lock_state, CurrentLockState::UNLOCKED);
  192. this->lock_state = CurrentLockState::UPGRADE;
  193. }
  194. void unlock_upgrade() {
  195. EXPECT_EQ(this->lock_state, CurrentLockState::UPGRADE);
  196. this->lock_state = CurrentLockState::UNLOCKED;
  197. }
  198. void unlock_upgrade_and_lock() {
  199. EXPECT_EQ(this->lock_state, CurrentLockState::UPGRADE);
  200. this->lock_state = CurrentLockState::UNIQUE;
  201. }
  202. void unlock_and_lock_upgrade() {
  203. EXPECT_EQ(this->lock_state, CurrentLockState::UNIQUE);
  204. this->lock_state = CurrentLockState::UPGRADE;
  205. }
  206. void unlock_and_lock_shared() {
  207. EXPECT_EQ(this->lock_state, CurrentLockState::UNIQUE);
  208. this->lock_state = CurrentLockState::SHARED;
  209. }
  210. void unlock_upgrade_and_lock_shared() {
  211. EXPECT_EQ(this->lock_state, CurrentLockState::UPGRADE);
  212. this->lock_state = CurrentLockState::SHARED;
  213. }
  214. template <class Rep, class Period>
  215. bool try_lock_for(const std::chrono::duration<Rep, Period>&) {
  216. EXPECT_EQ(this->lock_state, CurrentLockState::UNLOCKED);
  217. this->lock_state = CurrentLockState::UNIQUE;
  218. return true;
  219. }
  220. template <class Rep, class Period>
  221. bool try_lock_upgrade_for(const std::chrono::duration<Rep, Period>&) {
  222. EXPECT_EQ(this->lock_state, CurrentLockState::UNLOCKED);
  223. this->lock_state = CurrentLockState::UPGRADE;
  224. return true;
  225. }
  226. template <class Rep, class Period>
  227. bool try_unlock_upgrade_and_lock_for(
  228. const std::chrono::duration<Rep, Period>&) {
  229. EXPECT_EQ(this->lock_state, CurrentLockState::UPGRADE);
  230. this->lock_state = CurrentLockState::UNIQUE;
  231. return true;
  232. }
  233. /*
  234. * Initialize the FakeMutex with an unlocked state
  235. */
  236. CurrentLockState lock_state{CurrentLockState::UNLOCKED};
  237. };
  238. /**
  239. * The following works around the internal mutex for synchronized being
  240. * private
  241. *
  242. * This is horridly thread unsafe.
  243. */
  244. static FakeAllPowerfulAssertingMutexInternal globalAllPowerfulAssertingMutex;
  245. class FakeAllPowerfulAssertingMutex {
  246. public:
  247. void lock() {
  248. globalAllPowerfulAssertingMutex.lock();
  249. }
  250. void unlock() {
  251. globalAllPowerfulAssertingMutex.unlock();
  252. }
  253. void lock_shared() {
  254. globalAllPowerfulAssertingMutex.lock_shared();
  255. }
  256. void unlock_shared() {
  257. globalAllPowerfulAssertingMutex.unlock_shared();
  258. }
  259. void lock_upgrade() {
  260. globalAllPowerfulAssertingMutex.lock_upgrade();
  261. }
  262. void unlock_upgrade() {
  263. globalAllPowerfulAssertingMutex.unlock_upgrade();
  264. }
  265. void unlock_upgrade_and_lock() {
  266. globalAllPowerfulAssertingMutex.unlock_upgrade_and_lock();
  267. }
  268. void unlock_and_lock_upgrade() {
  269. globalAllPowerfulAssertingMutex.unlock_and_lock_upgrade();
  270. }
  271. void unlock_and_lock_shared() {
  272. globalAllPowerfulAssertingMutex.unlock_and_lock_shared();
  273. }
  274. void unlock_upgrade_and_lock_shared() {
  275. globalAllPowerfulAssertingMutex.unlock_upgrade_and_lock_shared();
  276. }
  277. template <class Rep, class Period>
  278. bool try_lock_for(const std::chrono::duration<Rep, Period>& arg) {
  279. return globalAllPowerfulAssertingMutex.try_lock_for(arg);
  280. }
  281. template <class Rep, class Period>
  282. bool try_lock_upgrade_for(const std::chrono::duration<Rep, Period>& arg) {
  283. return globalAllPowerfulAssertingMutex.try_lock_upgrade_for(arg);
  284. }
  285. template <class Rep, class Period>
  286. bool try_unlock_upgrade_and_lock_for(
  287. const std::chrono::duration<Rep, Period>& arg) {
  288. return globalAllPowerfulAssertingMutex.try_unlock_upgrade_and_lock_for(arg);
  289. }
  290. // reset state on destruction
  291. ~FakeAllPowerfulAssertingMutex() {
  292. globalAllPowerfulAssertingMutex = FakeAllPowerfulAssertingMutexInternal{};
  293. }
  294. };
  295. class NonDefaultConstructibleMutex {
  296. public:
  297. explicit NonDefaultConstructibleMutex(int valueIn) {
  298. value = valueIn;
  299. }
  300. NonDefaultConstructibleMutex() = delete;
  301. NonDefaultConstructibleMutex(const NonDefaultConstructibleMutex&) = delete;
  302. NonDefaultConstructibleMutex(NonDefaultConstructibleMutex&&) = delete;
  303. NonDefaultConstructibleMutex& operator=(const NonDefaultConstructibleMutex&) =
  304. delete;
  305. NonDefaultConstructibleMutex& operator=(NonDefaultConstructibleMutex&&) =
  306. delete;
  307. static int value;
  308. void lock() {}
  309. void unlock() {}
  310. };
  311. int NonDefaultConstructibleMutex::value{0};
  312. TEST_F(SynchronizedLockTest, TestCopyConstructibleValues) {
  313. struct NonCopyConstructible {
  314. NonCopyConstructible(const NonCopyConstructible&) = delete;
  315. NonCopyConstructible& operator=(const NonCopyConstructible&) = delete;
  316. };
  317. struct CopyConstructible {};
  318. EXPECT_FALSE(std::is_copy_constructible<
  319. folly::Synchronized<NonCopyConstructible>>::value);
  320. EXPECT_FALSE(std::is_copy_assignable<
  321. folly::Synchronized<NonCopyConstructible>>::value);
  322. EXPECT_TRUE(std::is_copy_constructible<
  323. folly::Synchronized<CopyConstructible>>::value);
  324. EXPECT_TRUE(
  325. std::is_copy_assignable<folly::Synchronized<CopyConstructible>>::value);
  326. }
  327. TEST_F(SynchronizedLockTest, UpgradableLocking) {
  328. folly::Synchronized<int, FakeAllPowerfulAssertingMutex> sync;
  329. // sanity assert
  330. static_assert(
  331. std::is_same<std::decay<decltype(*sync.ulock())>::type, int>::value,
  332. "The ulock function was not well configured, blame aary@instagram.com");
  333. {
  334. auto ulock = sync.ulock();
  335. EXPECT_EQ(
  336. globalAllPowerfulAssertingMutex.lock_state,
  337. FakeAllPowerfulAssertingMutexInternal::CurrentLockState::UPGRADE);
  338. }
  339. // should be unlocked here
  340. EXPECT_EQ(
  341. globalAllPowerfulAssertingMutex.lock_state,
  342. FakeAllPowerfulAssertingMutexInternal::CurrentLockState::UNLOCKED);
  343. // test going from upgrade to exclusive
  344. {
  345. auto ulock = sync.ulock();
  346. auto wlock = ulock.moveFromUpgradeToWrite();
  347. EXPECT_EQ(static_cast<bool>(ulock), false);
  348. EXPECT_EQ(
  349. globalAllPowerfulAssertingMutex.lock_state,
  350. FakeAllPowerfulAssertingMutexInternal::CurrentLockState::UNIQUE);
  351. }
  352. // should be unlocked here
  353. EXPECT_EQ(
  354. globalAllPowerfulAssertingMutex.lock_state,
  355. FakeAllPowerfulAssertingMutexInternal::CurrentLockState::UNLOCKED);
  356. // test going from upgrade to shared
  357. {
  358. auto ulock = sync.ulock();
  359. auto slock = ulock.moveFromUpgradeToRead();
  360. EXPECT_EQ(static_cast<bool>(ulock), false);
  361. EXPECT_EQ(
  362. globalAllPowerfulAssertingMutex.lock_state,
  363. FakeAllPowerfulAssertingMutexInternal::CurrentLockState::SHARED);
  364. }
  365. // should be unlocked here
  366. EXPECT_EQ(
  367. globalAllPowerfulAssertingMutex.lock_state,
  368. FakeAllPowerfulAssertingMutexInternal::CurrentLockState::UNLOCKED);
  369. // test going from exclusive to upgrade
  370. {
  371. auto wlock = sync.wlock();
  372. auto ulock = wlock.moveFromWriteToUpgrade();
  373. EXPECT_EQ(static_cast<bool>(wlock), false);
  374. EXPECT_EQ(
  375. globalAllPowerfulAssertingMutex.lock_state,
  376. FakeAllPowerfulAssertingMutexInternal::CurrentLockState::UPGRADE);
  377. }
  378. // should be unlocked here
  379. EXPECT_EQ(
  380. globalAllPowerfulAssertingMutex.lock_state,
  381. FakeAllPowerfulAssertingMutexInternal::CurrentLockState::UNLOCKED);
  382. // test going from exclusive to shared
  383. {
  384. auto wlock = sync.wlock();
  385. auto slock = wlock.moveFromWriteToRead();
  386. EXPECT_EQ(static_cast<bool>(wlock), false);
  387. EXPECT_EQ(
  388. globalAllPowerfulAssertingMutex.lock_state,
  389. FakeAllPowerfulAssertingMutexInternal::CurrentLockState::SHARED);
  390. }
  391. // should be unlocked here
  392. EXPECT_EQ(
  393. globalAllPowerfulAssertingMutex.lock_state,
  394. FakeAllPowerfulAssertingMutexInternal::CurrentLockState::UNLOCKED);
  395. }
  396. TEST_F(SynchronizedLockTest, UpgradableLockingWithULock) {
  397. folly::Synchronized<int, FakeAllPowerfulAssertingMutex> sync;
  398. // sanity assert
  399. static_assert(
  400. std::is_same<std::decay<decltype(*sync.ulock())>::type, int>::value,
  401. "The ulock function was not well configured, blame aary@instagram.com");
  402. // test from upgrade to write
  403. sync.withULockPtr([](auto ulock) {
  404. EXPECT_EQ(static_cast<bool>(ulock), true);
  405. EXPECT_EQ(
  406. globalAllPowerfulAssertingMutex.lock_state,
  407. FakeAllPowerfulAssertingMutexInternal::CurrentLockState::UPGRADE);
  408. auto wlock = ulock.moveFromUpgradeToWrite();
  409. EXPECT_EQ(static_cast<bool>(ulock), false);
  410. EXPECT_EQ(
  411. globalAllPowerfulAssertingMutex.lock_state,
  412. FakeAllPowerfulAssertingMutexInternal::CurrentLockState::UNIQUE);
  413. });
  414. // should be unlocked here
  415. EXPECT_EQ(
  416. globalAllPowerfulAssertingMutex.lock_state,
  417. FakeAllPowerfulAssertingMutexInternal::CurrentLockState::UNLOCKED);
  418. // test from write to upgrade
  419. sync.withWLockPtr([](auto wlock) {
  420. EXPECT_EQ(static_cast<bool>(wlock), true);
  421. EXPECT_EQ(
  422. globalAllPowerfulAssertingMutex.lock_state,
  423. FakeAllPowerfulAssertingMutexInternal::CurrentLockState::UNIQUE);
  424. auto ulock = wlock.moveFromWriteToUpgrade();
  425. EXPECT_EQ(static_cast<bool>(wlock), false);
  426. EXPECT_EQ(
  427. globalAllPowerfulAssertingMutex.lock_state,
  428. FakeAllPowerfulAssertingMutexInternal::CurrentLockState::UPGRADE);
  429. });
  430. // should be unlocked here
  431. EXPECT_EQ(
  432. globalAllPowerfulAssertingMutex.lock_state,
  433. FakeAllPowerfulAssertingMutexInternal::CurrentLockState::UNLOCKED);
  434. // test from upgrade to shared
  435. sync.withULockPtr([](auto ulock) {
  436. EXPECT_EQ(static_cast<bool>(ulock), true);
  437. EXPECT_EQ(
  438. globalAllPowerfulAssertingMutex.lock_state,
  439. FakeAllPowerfulAssertingMutexInternal::CurrentLockState::UPGRADE);
  440. auto slock = ulock.moveFromUpgradeToRead();
  441. EXPECT_EQ(static_cast<bool>(ulock), false);
  442. EXPECT_EQ(
  443. globalAllPowerfulAssertingMutex.lock_state,
  444. FakeAllPowerfulAssertingMutexInternal::CurrentLockState::SHARED);
  445. });
  446. // should be unlocked here
  447. EXPECT_EQ(
  448. globalAllPowerfulAssertingMutex.lock_state,
  449. FakeAllPowerfulAssertingMutexInternal::CurrentLockState::UNLOCKED);
  450. // test from write to shared
  451. sync.withWLockPtr([](auto wlock) {
  452. EXPECT_EQ(static_cast<bool>(wlock), true);
  453. EXPECT_EQ(
  454. globalAllPowerfulAssertingMutex.lock_state,
  455. FakeAllPowerfulAssertingMutexInternal::CurrentLockState::UNIQUE);
  456. auto slock = wlock.moveFromWriteToRead();
  457. EXPECT_EQ(static_cast<bool>(wlock), false);
  458. EXPECT_EQ(
  459. globalAllPowerfulAssertingMutex.lock_state,
  460. FakeAllPowerfulAssertingMutexInternal::CurrentLockState::SHARED);
  461. });
  462. // should be unlocked here
  463. EXPECT_EQ(
  464. globalAllPowerfulAssertingMutex.lock_state,
  465. FakeAllPowerfulAssertingMutexInternal::CurrentLockState::UNLOCKED);
  466. }
  467. TEST_F(SynchronizedLockTest, TestPieceWiseConstruct) {
  468. auto&& synchronized = folly::Synchronized<int, NonDefaultConstructibleMutex>{
  469. std::piecewise_construct,
  470. std::forward_as_tuple(3),
  471. std::forward_as_tuple(1)};
  472. EXPECT_EQ(*synchronized.lock(), 3);
  473. EXPECT_EQ(NonDefaultConstructibleMutex::value, 1);
  474. }
  475. namespace {
  476. constexpr auto kLockable = 1;
  477. constexpr auto kWLockable = 2;
  478. constexpr auto kRLockable = 4;
  479. constexpr auto kULockable = 8;
  480. template <int kLockableType>
  481. class TryLockable {
  482. public:
  483. explicit TryLockable(
  484. bool shouldSucceed,
  485. folly::Function<void()> onLockIn,
  486. folly::Function<void()> onUnlockIn)
  487. : kShouldSucceed{shouldSucceed},
  488. onLock{std::move(onLockIn)},
  489. onUnlock{std::move(onUnlockIn)} {}
  490. void lock() {
  491. EXPECT_TRUE(false);
  492. }
  493. template <
  494. int LockableType = kLockableType,
  495. std::enable_if_t<LockableType != kLockable>* = nullptr>
  496. void lock_shared() {
  497. EXPECT_TRUE(false);
  498. }
  499. template <
  500. int LockableType = kLockableType,
  501. std::enable_if_t<LockableType == kULockable>* = nullptr>
  502. void lock_upgrade() {
  503. EXPECT_TRUE(false);
  504. }
  505. bool tryLockImpl(int lockableMask) {
  506. // if the lockable type of this instance is one of the possible options as
  507. // expressed in the mask go through the usual test code
  508. if (kLockableType | lockableMask) {
  509. if (kShouldSucceed) {
  510. onLock();
  511. return true;
  512. } else {
  513. return false;
  514. }
  515. }
  516. // else fail the test
  517. EXPECT_TRUE(false);
  518. return false;
  519. }
  520. void unlockImpl(int lockableMask) {
  521. if (kLockableType | lockableMask) {
  522. onUnlock();
  523. return;
  524. }
  525. EXPECT_TRUE(false);
  526. }
  527. bool try_lock() {
  528. return tryLockImpl(kLockable | kWLockable);
  529. }
  530. bool try_lock_shared() {
  531. return tryLockImpl(kRLockable);
  532. }
  533. bool try_lock_upgrade() {
  534. return tryLockImpl(kULockable);
  535. }
  536. void unlock() {
  537. unlockImpl(kLockable | kWLockable);
  538. }
  539. void unlock_shared() {
  540. unlockImpl(kLockable | kRLockable);
  541. }
  542. void unlock_upgrade() {
  543. unlockImpl(kLockable | kULockable);
  544. }
  545. const bool kShouldSucceed;
  546. folly::Function<void()> onLock;
  547. folly::Function<void()> onUnlock;
  548. };
  549. struct TestSharedMutex {
  550. public:
  551. void lock() {
  552. onLock_();
  553. }
  554. void unlock() {
  555. onUnlock_();
  556. }
  557. void lock_shared() {
  558. onLockShared_();
  559. }
  560. void unlock_shared() {
  561. onUnlockShared_();
  562. }
  563. bool try_lock() {
  564. onLock_();
  565. return true;
  566. }
  567. bool try_lock_shared() {
  568. onLockShared_();
  569. return true;
  570. }
  571. std::function<void()> onLock_;
  572. std::function<void()> onUnlock_;
  573. std::function<void()> onLockShared_;
  574. std::function<void()> onUnlockShared_;
  575. };
  576. struct TestMutex {
  577. public:
  578. void lock() {
  579. onLock();
  580. ++numTimesLocked;
  581. }
  582. bool try_lock() {
  583. if (shouldTryLockSucceed) {
  584. lock();
  585. return true;
  586. }
  587. return false;
  588. }
  589. void unlock() {
  590. onUnlock();
  591. ++numTimesUnlocked;
  592. }
  593. int numTimesLocked{0};
  594. int numTimesUnlocked{0};
  595. bool shouldTryLockSucceed{true};
  596. std::function<void()> onLock{[] {}};
  597. std::function<void()> onUnlock{[] {}};
  598. };
  599. template <int kLockable, typename Func>
  600. void testTryLock(Func func) {
  601. {
  602. auto locked = 0;
  603. auto unlocked = 0;
  604. folly::Synchronized<int, TryLockable<kLockable>> synchronized{
  605. std::piecewise_construct,
  606. std::make_tuple(),
  607. std::make_tuple(true, [&] { ++locked; }, [&] { ++unlocked; })};
  608. {
  609. auto lock = func(synchronized);
  610. EXPECT_TRUE(lock);
  611. EXPECT_EQ(locked, 1);
  612. }
  613. EXPECT_EQ(locked, 1);
  614. EXPECT_EQ(unlocked, 1);
  615. }
  616. {
  617. auto locked = 0;
  618. auto unlocked = 0;
  619. folly::Synchronized<int, TryLockable<kLockable>> synchronized{
  620. std::piecewise_construct,
  621. std::make_tuple(),
  622. std::make_tuple(false, [&] { ++locked; }, [&] { ++unlocked; })};
  623. {
  624. auto lock = func(synchronized);
  625. EXPECT_FALSE(lock);
  626. EXPECT_EQ(locked, 0);
  627. }
  628. EXPECT_EQ(locked, 0);
  629. EXPECT_EQ(unlocked, 0);
  630. }
  631. }
  632. class MutexTrack {
  633. public:
  634. static int gId;
  635. static int gOrder;
  636. void lock_shared() {}
  637. void unlock_shared() {}
  638. void lock() {
  639. order = MutexTrack::gOrder++;
  640. }
  641. void unlock() {
  642. order = -1;
  643. --gOrder;
  644. }
  645. int current{gId++};
  646. int order{-1};
  647. };
  648. int MutexTrack::gId{0};
  649. int MutexTrack::gOrder{0};
  650. } // namespace
  651. TEST_F(SynchronizedLockTest, TestTryLock) {
  652. testTryLock<kLockable>(
  653. [](auto& synchronized) { return synchronized.tryLock(); });
  654. }
  655. TEST_F(SynchronizedLockTest, TestTryWLock) {
  656. testTryLock<kWLockable>(
  657. [](auto& synchronized) { return synchronized.tryWLock(); });
  658. }
  659. TEST_F(SynchronizedLockTest, TestTryRLock) {
  660. testTryLock<kRLockable>(
  661. [](auto& synchronized) { return synchronized.tryRLock(); });
  662. }
  663. TEST_F(SynchronizedLockTest, TestTryULock) {
  664. testTryLock<kULockable>(
  665. [](auto& synchronized) { return synchronized.tryULock(); });
  666. }
  667. template <typename LockPolicy>
  668. using LPtr = LockedPtr<Synchronized<int>, LockPolicy>;
  669. namespace {
  670. template <template <typename...> class Trait>
  671. void testLockedPtrCompatibilityExclusive() {
  672. EXPECT_TRUE((
  673. Trait<LPtr<LockPolicyExclusive>, LPtr<LockPolicyTryExclusive>&&>::value));
  674. EXPECT_TRUE((Trait<
  675. LPtr<LockPolicyExclusive>,
  676. LPtr<LockPolicyFromUpgradeToExclusive>&&>::value));
  677. EXPECT_FALSE(
  678. (Trait<LPtr<LockPolicyExclusive>&, LPtr<LockPolicyShared>&&>::value));
  679. EXPECT_FALSE(
  680. (Trait<LPtr<LockPolicyExclusive>, LPtr<LockPolicyTryShared>&&>::value));
  681. EXPECT_FALSE(
  682. (Trait<LPtr<LockPolicyExclusive>, LPtr<LockPolicyUpgrade>&&>::value));
  683. EXPECT_FALSE(
  684. (Trait<LPtr<LockPolicyExclusive>, LPtr<LockPolicyTryUpgrade>&&>::value));
  685. EXPECT_FALSE((Trait<
  686. LPtr<LockPolicyExclusive>,
  687. LPtr<LockPolicyFromExclusiveToUpgrade>&&>::value));
  688. EXPECT_FALSE((Trait<
  689. LPtr<LockPolicyExclusive>,
  690. LPtr<LockPolicyFromExclusiveToShared>&&>::value));
  691. EXPECT_FALSE(
  692. (Trait<LPtr<LockPolicyExclusive>, LPtr<LockPolicyFromUpgradeToShared>&&>::
  693. value));
  694. }
  695. template <template <typename...> class Trait>
  696. void testLockedPtrCompatibilityShared() {
  697. EXPECT_TRUE(
  698. (Trait<LPtr<LockPolicyShared>, LPtr<LockPolicyTryShared>&&>::value));
  699. EXPECT_TRUE(
  700. (Trait<LPtr<LockPolicyShared>, LPtr<LockPolicyFromUpgradeToShared>&&>::
  701. value));
  702. EXPECT_TRUE(
  703. (Trait<LPtr<LockPolicyShared>, LPtr<LockPolicyFromExclusiveToShared>&&>::
  704. value));
  705. EXPECT_FALSE(
  706. (Trait<LPtr<LockPolicyShared>, LPtr<LockPolicyExclusive>&&>::value));
  707. EXPECT_FALSE(
  708. (Trait<LPtr<LockPolicyShared>, LPtr<LockPolicyTryExclusive>&&>::value));
  709. EXPECT_FALSE(
  710. (Trait<LPtr<LockPolicyShared>, LPtr<LockPolicyUpgrade>&&>::value));
  711. EXPECT_FALSE(
  712. (Trait<LPtr<LockPolicyShared>, LPtr<LockPolicyTryUpgrade>&&>::value));
  713. EXPECT_FALSE(
  714. (Trait<LPtr<LockPolicyShared>, LPtr<LockPolicyFromExclusiveToUpgrade>&&>::
  715. value));
  716. EXPECT_FALSE(
  717. (Trait<LPtr<LockPolicyShared>, LPtr<LockPolicyFromUpgradeToExclusive>&&>::
  718. value));
  719. }
  720. template <template <typename...> class Trait>
  721. void testLockedPtrCompatibilityUpgrade() {
  722. EXPECT_TRUE(
  723. (Trait<LPtr<LockPolicyUpgrade>, LPtr<LockPolicyTryUpgrade>&&>::value));
  724. EXPECT_TRUE((
  725. Trait<LPtr<LockPolicyUpgrade>, LPtr<LockPolicyFromExclusiveToUpgrade>&&>::
  726. value));
  727. EXPECT_FALSE(
  728. (Trait<LPtr<LockPolicyUpgrade>, LPtr<LockPolicyExclusive>&&>::value));
  729. EXPECT_FALSE(
  730. (Trait<LPtr<LockPolicyUpgrade>, LPtr<LockPolicyTryExclusive>&&>::value));
  731. EXPECT_FALSE(
  732. (Trait<LPtr<LockPolicyUpgrade>, LPtr<LockPolicyShared>&&>::value));
  733. EXPECT_FALSE(
  734. (Trait<LPtr<LockPolicyUpgrade>, LPtr<LockPolicyTryShared>&&>::value));
  735. EXPECT_FALSE(
  736. (Trait<LPtr<LockPolicyUpgrade>, LPtr<LockPolicyFromExclusiveToShared>&&>::
  737. value));
  738. EXPECT_FALSE(
  739. (Trait<LPtr<LockPolicyUpgrade>, LPtr<LockPolicyFromUpgradeToShared>&&>::
  740. value));
  741. EXPECT_FALSE((
  742. Trait<LPtr<LockPolicyUpgrade>, LPtr<LockPolicyFromUpgradeToExclusive>&&>::
  743. value));
  744. }
  745. } // namespace
  746. TEST_F(SynchronizedLockTest, TestLockedPtrCompatibilityExclusive) {
  747. testLockedPtrCompatibilityExclusive<std::is_assignable>();
  748. testLockedPtrCompatibilityExclusive<std::is_constructible>();
  749. }
  750. TEST_F(SynchronizedLockTest, TestLockedPtrCompatibilityShared) {
  751. testLockedPtrCompatibilityShared<std::is_assignable>();
  752. testLockedPtrCompatibilityShared<std::is_constructible>();
  753. }
  754. TEST_F(SynchronizedLockTest, TestLockedPtrCompatibilityUpgrade) {
  755. testLockedPtrCompatibilityUpgrade<std::is_assignable>();
  756. testLockedPtrCompatibilityUpgrade<std::is_constructible>();
  757. }
  758. TEST_F(SynchronizedLockTest, TestConvertTryLockToLock) {
  759. auto synchronized = folly::Synchronized<int>{0};
  760. auto wlock = synchronized.wlock();
  761. wlock.unlock();
  762. auto ulock = synchronized.ulock();
  763. wlock = ulock.moveFromUpgradeToWrite();
  764. wlock.unlock();
  765. auto value = synchronized.withWLock([](auto& integer) { return integer; });
  766. EXPECT_EQ(value, 0);
  767. }
  768. TEST(FollyLockTest, TestVariadicLockWithSynchronized) {
  769. {
  770. auto syncs = std::array<folly::Synchronized<int>, 3>{};
  771. auto& one = syncs[0];
  772. auto const& two = syncs[1];
  773. auto& three = syncs[2];
  774. auto locks =
  775. lock(folly::wlock(one), folly::rlock(two), folly::wlock(three));
  776. EXPECT_TRUE(std::get<0>(locks));
  777. EXPECT_TRUE(std::get<1>(locks));
  778. EXPECT_TRUE(std::get<2>(locks));
  779. }
  780. {
  781. auto syncs = std::array<folly::Synchronized<int, std::mutex>, 2>{};
  782. auto locks = lock(folly::lock(syncs[0]), folly::lock(syncs[1]));
  783. EXPECT_TRUE(std::get<0>(locks));
  784. EXPECT_TRUE(std::get<1>(locks));
  785. }
  786. }
  787. TEST(FollyLockTest, TestVariadicLockWithArbitraryLockables) {
  788. auto&& one = std::mutex{};
  789. auto&& two = std::mutex{};
  790. auto lckOne = std::unique_lock<std::mutex>{one, std::defer_lock};
  791. auto lckTwo = std::unique_lock<std::mutex>{two, std::defer_lock};
  792. folly::lock(lckOne, lckTwo);
  793. EXPECT_TRUE(lckOne);
  794. EXPECT_TRUE(lckTwo);
  795. }
  796. TEST(FollyLockTest, TestVariadicLockSmartAndPoliteAlgorithm) {
  797. auto one = TestMutex{};
  798. auto two = TestMutex{};
  799. auto three = TestMutex{};
  800. auto makeReset = [&] {
  801. return folly::makeGuard([&] {
  802. one = TestMutex{};
  803. two = TestMutex{};
  804. three = TestMutex{};
  805. });
  806. };
  807. {
  808. auto reset = makeReset();
  809. folly::lock(one, two, three);
  810. EXPECT_EQ(one.numTimesLocked, 1);
  811. EXPECT_EQ(one.numTimesUnlocked, 0);
  812. EXPECT_EQ(two.numTimesLocked, 1);
  813. EXPECT_EQ(two.numTimesUnlocked, 0);
  814. EXPECT_EQ(three.numTimesLocked, 1);
  815. EXPECT_EQ(three.numTimesUnlocked, 0);
  816. }
  817. {
  818. auto reset = makeReset();
  819. two.shouldTryLockSucceed = false;
  820. folly::lock(one, two, three);
  821. EXPECT_EQ(one.numTimesLocked, 2);
  822. EXPECT_EQ(one.numTimesUnlocked, 1);
  823. EXPECT_EQ(two.numTimesLocked, 1);
  824. EXPECT_EQ(two.numTimesUnlocked, 0);
  825. EXPECT_EQ(three.numTimesLocked, 1);
  826. EXPECT_EQ(three.numTimesUnlocked, 0);
  827. }
  828. {
  829. auto reset = makeReset();
  830. three.shouldTryLockSucceed = false;
  831. folly::lock(one, two, three);
  832. EXPECT_EQ(one.numTimesLocked, 2);
  833. EXPECT_EQ(one.numTimesUnlocked, 1);
  834. EXPECT_EQ(two.numTimesLocked, 2);
  835. EXPECT_EQ(two.numTimesUnlocked, 1);
  836. EXPECT_EQ(three.numTimesLocked, 1);
  837. EXPECT_EQ(three.numTimesUnlocked, 0);
  838. }
  839. {
  840. auto reset = makeReset();
  841. three.shouldTryLockSucceed = false;
  842. three.onLock = [&] {
  843. // when three gets locked make one fail
  844. one.shouldTryLockSucceed = false;
  845. // then when one gets locked make three succeed to finish the test
  846. one.onLock = [&] { three.shouldTryLockSucceed = true; };
  847. };
  848. folly::lock(one, two, three);
  849. EXPECT_EQ(one.numTimesLocked, 2);
  850. EXPECT_EQ(one.numTimesUnlocked, 1);
  851. EXPECT_EQ(two.numTimesLocked, 2);
  852. EXPECT_EQ(two.numTimesUnlocked, 1);
  853. EXPECT_EQ(three.numTimesLocked, 2);
  854. EXPECT_EQ(three.numTimesUnlocked, 1);
  855. }
  856. }
  857. TEST(SynchronizedAlgorithmTest, Basic) {
  858. auto sync = Synchronized<int>{0};
  859. auto value = synchronized([](auto s) { return *s; }, wlock(sync));
  860. EXPECT_EQ(value, 0);
  861. }
  862. TEST(SynchronizedAlgorithmTest, BasicNonShareableMutex) {
  863. auto sync = Synchronized<int, std::mutex>{0};
  864. auto value = synchronized([](auto s) { return *s; }, lock(sync));
  865. EXPECT_EQ(value, 0);
  866. }
  867. TEST(Synchronized, SynchronizedFunctionNonConst) {
  868. auto locked = 0;
  869. auto unlocked = 0;
  870. auto sync = Synchronized<int, TestSharedMutex>{
  871. std::piecewise_construct,
  872. std::make_tuple(0),
  873. std::make_tuple([&] { ++locked; }, [&] { ++unlocked; }, [] {}, [] {})};
  874. synchronized([](auto) {}, wlock(sync));
  875. EXPECT_EQ(locked, 1);
  876. EXPECT_EQ(unlocked, 1);
  877. }
  878. TEST(Synchronized, SynchronizedFunctionConst) {
  879. auto locked = 0;
  880. auto unlocked = 0;
  881. auto sync = Synchronized<int, TestSharedMutex>{
  882. std::piecewise_construct,
  883. std::make_tuple(0),
  884. std::make_tuple([] {}, [] {}, [&] { ++locked; }, [&] { ++unlocked; })};
  885. synchronized([](auto) {}, rlock(sync));
  886. EXPECT_EQ(locked, 1);
  887. EXPECT_EQ(unlocked, 1);
  888. }
  889. TEST(Synchronized, SynchronizedFunctionManyObjects) {
  890. auto fail = [] { EXPECT_TRUE(false); };
  891. auto pass = [] {};
  892. auto one = Synchronized<int, TestSharedMutex>{
  893. std::piecewise_construct,
  894. std::make_tuple(0),
  895. std::make_tuple(pass, pass, fail, fail)};
  896. auto two = Synchronized<std::string, TestSharedMutex>{
  897. std::piecewise_construct,
  898. std::make_tuple(),
  899. std::make_tuple(fail, fail, pass, pass)};
  900. synchronized([](auto, auto) {}, wlock(one), rlock(two));
  901. }
  902. } // namespace folly